From 1ce509ffa59dc7a4b6225ebe88202e4e469e0fad Mon Sep 17 00:00:00 2001
From: Fred Boniface <fred@fjla.uk>
Date: Tue, 14 Oct 2025 20:52:09 +0100
Subject: [PATCH] Add utility functions to ease the setting of preferences

---
 src/lib/cards/NearToMeCard.svelte            |  3 +--
 src/lib/islands/quick-link-set-island.svelte | 22 ++++++--------------
 src/lib/scripts/preferenceUtil.ts            |  9 --------
 src/lib/stores/preferences.ts                | 18 ++++++++++++++++
 src/routes/more/settings/+page.svelte        |  3 +--
 5 files changed, 26 insertions(+), 29 deletions(-)
 delete mode 100644 src/lib/scripts/preferenceUtil.ts

diff --git a/src/lib/cards/NearToMeCard.svelte b/src/lib/cards/NearToMeCard.svelte
index dbd5b9c..4c5efb3 100644
--- a/src/lib/cards/NearToMeCard.svelte
+++ b/src/lib/cards/NearToMeCard.svelte
@@ -5,14 +5,13 @@
     import type { CardConfig } from "./Card.types";
     import type { NearestStationResponse } from "@owlboard/ts-types";
     import { uuid } from "$lib/stores/uuid";
-    import { preferences } from "$lib/stores/preferences";
+    import { preferences, togglePreference } from "$lib/stores/preferences";
     import InLineLoading from "$lib/navigation/InLineLoading.svelte";
     import { apiGet } from "$lib/scripts/apiFetch";
     import { onMount } from "svelte";
     import { nearToMeCache } from "$lib/stores/nearToMeCache";
     import LinkButton from "$lib/buttons/LinkButton.svelte";
     import ScriptButton from "$lib/buttons/ScriptButton.svelte";
-    import { togglePreference } from "$lib/scripts/preferenceUtil";
 
     let errorMessage: string;
     let stations: NearestStationResponse[] = [];
diff --git a/src/lib/islands/quick-link-set-island.svelte b/src/lib/islands/quick-link-set-island.svelte
index f6b24ec..94691a8 100644
--- a/src/lib/islands/quick-link-set-island.svelte
+++ b/src/lib/islands/quick-link-set-island.svelte
@@ -1,7 +1,7 @@
 <script lang="ts">
     import Island from "$lib/islands/island.svelte";
     import type { Preferences } from "$lib/stores/preferences";
-    import { preferences } from "$lib/stores/preferences";
+    import { preferences, setQl, clearQl, addQlItem } from "$lib/stores/preferences";
     import toast from "svelte-french-toast";
     export let variables = {
         title: "Quick Links",
@@ -38,30 +38,20 @@
             }
         }
         console.log(inputLinks);
-        preferences.update((p: Preferences) => ({
-            ...p,
-            ql: inputLinks,
-        }))
+        setQl(inputLinks);
         await timeout(1000);
         saveButton = "Saved";
     }
 
-    function clearQl(): void {
-        preferences.update((p: Preferences) => ({
-            ...p,
-            ql: [],
-        }))
+    function clearQlSettings(): void {
+        clearQl();
         saveButton = "Saved";
         toast.success("Cleared Quick Links.");
     }
 
     function addQlBox(): void {
         saveButton = "Save";
-        const updatedQl = [...qlData, ""];
-        preferences.update((p: Preferences) => ({
-            ...p,
-            ql: updatedQl,
-        }))
+        addQlItem("");
     }
 
     function handleClick(event: any): void {
@@ -83,7 +73,7 @@
         <button on:click={addQlBox} id="qlAdd">+</button>
     </div>
     <button on:click={save}>{@html saveButton}</button>
-    <button on:click={clearQl}>Clear</button>
+    <button on:click={clearQlSettings}>Clear</button>
 </Island>
 
 <style>
diff --git a/src/lib/scripts/preferenceUtil.ts b/src/lib/scripts/preferenceUtil.ts
deleted file mode 100644
index 65628ec..0000000
--- a/src/lib/scripts/preferenceUtil.ts
+++ /dev/null
@@ -1,9 +0,0 @@
-import type { Preferences } from "$lib/stores/preferences";
-import { preferences } from "$lib/stores/preferences";
-
-export function togglePreference<K extends keyof Preferences>(key: K, value: boolean): void {
-    preferences.update(p => ({
-        ...p,
-        [key]: value,
-    }));
-}
\ No newline at end of file
diff --git a/src/lib/stores/preferences.ts b/src/lib/stores/preferences.ts
index 769a031..fd723a9 100644
--- a/src/lib/stores/preferences.ts
+++ b/src/lib/stores/preferences.ts
@@ -59,3 +59,21 @@ try {
     console.error("Preferences migration failed, resetting store", e);
     preferences.reset();
 }
+
+// Utility Functions
+
+export function addQlItem(item: string): void {
+    preferences.update(p => ({ ...p, ql: [...p.ql, item] }));
+}
+
+export function setQl(items: string[]): void {
+    preferences.update(p => ({ ...p, ql: items }));
+}
+
+export function clearQl(): void {
+    preferences.update(p => ({ ...p, ql: [] }));
+}
+
+export function togglePreference<K extends keyof Preferences>(key: K, value: boolean): void {
+    preferences.update(p => ({ ...p, [key]: value }));
+}
diff --git a/src/routes/more/settings/+page.svelte b/src/routes/more/settings/+page.svelte
index e512492..e7733e2 100644
--- a/src/routes/more/settings/+page.svelte
+++ b/src/routes/more/settings/+page.svelte
@@ -3,8 +3,7 @@
     import Nav from "$lib/navigation/nav.svelte";
     import QlSet from "$lib/islands/quick-link-set-island.svelte";
     import Island from "$lib/islands/island.svelte";
-    import { preferences } from "$lib/stores/preferences";
-    import { togglePreference } from "$lib/scripts/preferenceUtil";
+    import { preferences, togglePreference } from "$lib/stores/preferences";
     import { getCurrentLocation } from "$lib/scripts/getLocation";
     import toast from "svelte-french-toast";
     const title = "Settings";