MomentJS Date Parsing issue #46

New Issue

fred.boniface · 2023-09-30T21:02:40+01:00

fred.boniface commented

2023-09-30 21:02:40 +01:00

From staffStation.ts:

function transformUnspecifiedDateTime(input: string): Date | undefined {
  logger.trace(
    "utils/translators/ldb/staffStation.transformUnspecifiedDateTime: Running"
  );
  if (!input) {
    return undefined;
  }
  const date = tz(input, "Europe/London");
  return date.toDate();
}

This usage of MomentJS is deprecated and will be removed in a future release. A moment object should be created using moment.ts(...) before converting that to a JS Date object.

Alternatively, the module could be updated to use moment objects throughout although the features offered aren't required beyond this function.

From staffStation.ts: ``` function transformUnspecifiedDateTime(input: string): Date | undefined { logger.trace( "utils/translators/ldb/staffStation.transformUnspecifiedDateTime: Running" ); if (!input) { return undefined; } const date = tz(input, "Europe/London"); return date.toDate(); } ``` This usage of MomentJS is deprecated and will be removed in a future release. A moment object should be created using `moment.ts(...)` before converting that to a JS Date object. Alternatively, the module could be updated to use moment objects throughout although the features offered aren't required beyond this function.

fred.boniface added the

bug

backend

labels 2023-09-30 21:02:40 +01:00

fred.boniface self-assigned this 2023-09-30 21:02:41 +01:00

~~fred.boniface referenced this issue 2023-10-12 22:16:30 +01:00~~

Missing PIS Code - YVP-FIT (Not Yet Exists) #28

fred.boniface added this to the Feb 2023 Release milestone 2023-11-09 14:40:35 +00:00

Sign in to join this conversation.