From dd96e95ce5fb66ab4c14f3ef7210d7a210106dfd Mon Sep 17 00:00:00 2001 From: Fred Boniface Date: Wed, 5 Apr 2023 01:08:14 +0100 Subject: [PATCH] Add better error codes Signed-off-by: Fred Boniface --- UpNext.md | 3 ++- src/controllers/kube.controllers.js | 1 + src/controllers/ldb.controllers.js | 1 + src/controllers/list.controllers.js | 3 +++ src/controllers/stats.controllers.js | 4 +++- src/routes/ldbs.routes.js | 19 +++++++++++++++++++ 6 files changed, 29 insertions(+), 2 deletions(-) create mode 100644 src/routes/ldbs.routes.js diff --git a/UpNext.md b/UpNext.md index 959ad6b..c7a1fe3 100644 --- a/UpNext.md +++ b/UpNext.md @@ -1,3 +1,4 @@ # What to do next: -* Rewrite sanitizing functions to remove external dependancy. \ No newline at end of file +* Rewrite sanitizing functions to remove external dependancy. +* Change /api/v1/auth endpoints to /api/v1/register endpoints - auth is done in middleware \ No newline at end of file diff --git a/src/controllers/kube.controllers.js b/src/controllers/kube.controllers.js index 2253aef..6d983cb 100644 --- a/src/controllers/kube.controllers.js +++ b/src/controllers/kube.controllers.js @@ -23,6 +23,7 @@ async function getTime(req, res, next){ res.json(await kube.getTime(req.body)) } catch (err) { console.error(`Unknown Error`, err.message); + err.status = 503 next(err); } } diff --git a/src/controllers/ldb.controllers.js b/src/controllers/ldb.controllers.js index 2c6917e..0261c67 100644 --- a/src/controllers/ldb.controllers.js +++ b/src/controllers/ldb.controllers.js @@ -6,6 +6,7 @@ async function get(req, res, next){ res.json(await ldb.get(req.body, id)) } catch (err) { console.error(`Unknown Error`, err.message); + err.status = 500 next(err); } } diff --git a/src/controllers/list.controllers.js b/src/controllers/list.controllers.js index 63fd1c4..1a59b3b 100644 --- a/src/controllers/list.controllers.js +++ b/src/controllers/list.controllers.js @@ -5,6 +5,7 @@ async function getStations(req, res, next){ res.json(await list.getStations(req.body)) } catch (err) { console.error(`Controller Error`, err.message); + err.status = 500 next(err); } } @@ -14,6 +15,7 @@ async function getCorpus(req, res, next){ res.json(await list.getCorpus(req.body)) } catch (err) { console.error(`Controller Error`, err.message); + err.status = 500 next(err); } } @@ -23,6 +25,7 @@ async function hits(req, res, next) { res.json(await list.hits()) } catch (err) { console.error(`Controller Error`, err); + err.status = 500 next(err); } } diff --git a/src/controllers/stats.controllers.js b/src/controllers/stats.controllers.js index f42e0f6..daabff5 100644 --- a/src/controllers/stats.controllers.js +++ b/src/controllers/stats.controllers.js @@ -5,9 +5,11 @@ async function get(req, res, next) { res.json(await stat.hits()) } catch (err) { console.error(`Controller Error`, err); + err.status = 500 next(err); } } module.exports = { - get} \ No newline at end of file + get +} \ No newline at end of file diff --git a/src/routes/ldbs.routes.js b/src/routes/ldbs.routes.js new file mode 100644 index 0000000..591bd45 --- /dev/null +++ b/src/routes/ldbs.routes.js @@ -0,0 +1,19 @@ +const express = require('express'); +const router = express.Router(); +const ldbController = require('../controllers/ldb.controllers'); + +/* GET programming languages. */ +//router.get('/', programmingLanguagesController.get); + +/* POST programming language */ +//router.post('/', programmingLanguagesController.create); + +/* PUT programming language */ +//router.put('/:id', programmingLanguagesController.update); + +/* DELETE programming language */ +//router.delete('/:id', programmingLanguagesController.remove); + +router.get('/:id', ldbController.get); + +module.exports = router; \ No newline at end of file