From 843a6cad977fe7dd67bdc12c1fc61ec97b40bd89 Mon Sep 17 00:00:00 2001 From: Fred Boniface Date: Mon, 11 Sep 2023 20:53:29 +0100 Subject: [PATCH] Fix bug where empty input to transform function does not return `null` Signed-off-by: Fred Boniface --- src/utils/translators/ldb/staffStation.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/utils/translators/ldb/staffStation.ts b/src/utils/translators/ldb/staffStation.ts index adc8ad8..0252631 100644 --- a/src/utils/translators/ldb/staffStation.ts +++ b/src/utils/translators/ldb/staffStation.ts @@ -16,7 +16,7 @@ export function transform(input: any): StaffLdb | null { try { output = { generatedAt: transformDateTime(data?.generatedAt) || new Date(), - locationName: data?.locationName || "Not Found", + locationName: data?.locationName || 'Not Found', stationManagerCode: data?.stationManagerCode || "UK", nrccMessages: transformNrcc(data?.nrccMessages) || undefined, trainServices: transformTrainServices(data?.trainServices) || undefined, @@ -24,7 +24,9 @@ export function transform(input: any): StaffLdb | null { ferryServices: transformTrainServices(data?.ferryServices) || undefined, }; console.timeEnd("StaffLdb Transformation"); - return output; + if (output.locationName !== 'Not Found') { + return output; + } } catch (err) { console.log("utils/translators/ldb/staffLdb.transform: Caught Error"); console.log("Unable to parse data, assuming no data: " + err);