Add getByRid to TrainsModule

.gitea/workflows/publish.yaml

@@ -4,7 +4,7 @@ on:
   push:
     tags:
       - "v*"
-
+ 
 jobs:
   build-and-publish:
     runs-on: ubuntu-22.04
@@ -19,7 +19,8 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: 20
-          registry-url: "https://git.fjla.uk/api/packages/npm/"
+          registry-url: 'https://git.fjla.uk/api/packages/owlboard/npm'
+          scope: '@OwlBoard'
 
       - name: Install Dependencies
         run: npm ci
@@ -27,12 +28,10 @@ jobs:
       - name: Build
         run: npm run build
 
-      # - name: Publish to NPM
-      #   run: npm publish --access public
-      #   env:
-      #     NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
-
       - name: Publish to Gitea Repo
-        run: npm publish
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.REPO_TOKEN }}
+        run: |
+          VERSION=${GITHUB_REF_NAME#v}
+          npm version $VERSION --no-git-tag-version
+          npm config set //git.fjla.uk/api/packages/owlboard/npm/:_authToken ${{ secrets.REPO_TOKEN }}
+          npm config set //git.fjla.uk/api/packages/OwlBoard/npm/:_authToken ${{ secrets.REPO_TOKEN }}
+          npm publish --registry=https://git.fjla.uk

package.json

@@ -1,12 +1,14 @@
 {
-  "name": "owlboard-ts",
+  "name": "@owlboard/owlboard-ts",
   "version": "3.0.0",
   "description": "TypeScript API Library to interact with the OwlBoard API (> v3.0.0)",
   "main": "./dist/index.js",
   "type": "module",
   "sideEffects": false,
   "types": "./dist/index.d.ts",
-  "files": ["dist"],
+  "files": [
+    "dist"
+  ],
   "exports": {
     ".": {
       "types": "./dist/index.d.ts",
@@ -28,9 +30,13 @@
   "author": "Frederick Boniface",
   "license": "GPL-3.0",
   "dependencies": {
-    "@owlboard/api-schema-types": "^3.0.1-alpha3"
+    "@owlboard/api-schema-types": "^3.0.3-alpha8",
+    "install": "^0.13.0",
+    "latlon-geohash": "^2.0.0",
+    "npm": "^11.13.0"
   },
   "devDependencies": {
+    "@types/latlon-geohash": "^2.0.4",
     "@types/node": "^25.3.0",
     "ts-node": "^10.9.2",
     "tsx": "^4.21.0",

src/index.ts

@@ -1,5 +1,11 @@
-export * from './lib/base.js';
-export * from './lib/client.js';
-export * from './lib/errors.js';
+export { OwlBoardClient } from './lib/client.js';
+export { ValidationError, ApiError, type ApiErrorCode } from './lib/errors.js';
 
-export * from './modules/pis.js';
+// Re-export API Schema types
+export type * from '@owlboard/api-schema-types'
+
+// Useful exports for Type Hinting
+export { PisModule } from './modules/pis.js';
+export { LocationFilterModule } from './modules/locationFilter.js';
+export { StationDataModule } from './modules/stationData.js';
+export { TrainsModule } from './modules/trains.js';

src/lib/base.ts

@@ -34,8 +34,9 @@ export class BaseClient {
 
     /**
      * Handles the Envelope logic
+     * @param fetcher - Optional custom fetch instance (e.g SvelteKit load fetch)
      */
-    public async request<T>(path: string, options: RequestInit = {}): Promise<ApiResult<T>> {
+    public async request<T>(path: string, options: RequestInit = {}, fetcher: typeof fetch = fetch): Promise<ApiResult<T>> {
         const url = `${this.baseUrl}${path}`;
         console.debug(`[API DEBUG] Calling: ${url}`);
         
@@ -43,7 +44,7 @@ export class BaseClient {
         headers.set('Content-Type', 'application/json');
         if (this.apiKey) headers.set('X-OWL-KEY', this.apiKey);
 
-        const response = await fetch(url, { ...options, headers });
+        const response = await fetcher(url, { ...options, headers });
 
         if (!response.ok && !response.headers.get('content-type')?.includes('application/json')) {
             throw new Error(`HTTP ${response.status}: ${response.statusText}`);

src/lib/client.ts

@@ -1,12 +1,21 @@
 import { BaseClient } from "./base.js";
 import { PisModule } from "../modules/pis.js";
+import { LocationFilterModule } from "../modules/locationFilter.js";
+import { StationDataModule } from "../modules/stationData.js";
+import { TrainsModule } from "../modules/trains.js";
 
 export class OwlBoardClient extends BaseClient {
     public readonly pis: PisModule;
+    public readonly locationFilter: LocationFilterModule;
+    public readonly stationData: StationDataModule;
+    public readonly trains: TrainsModule;
 
     constructor(baseUrl: string, apiKey?: string) {
         super(baseUrl, apiKey);
 
         this.pis = new PisModule(this);
+        this.locationFilter = new LocationFilterModule(this);
+        this.stationData = new StationDataModule(this);
+        this.trains = new TrainsModule(this);
     }
 }

src/lib/helpers.ts

@@ -0,0 +1,20 @@
+/**
+ * Normalises input to YYYY-MM-DD string
+ * - Strings are passed through as is
+ * - Date objects are converted to UK time
+ */
+export const ensureDateString = (input: Date | string): string => {
+    if (typeof input === 'string') return input.trim();
+
+    const d = new Intl.DateTimeFormat('en-GB', {
+        year: 'numeric',
+        month: '2-digit',
+        day: '2-digit',
+        timeZone: 'Europe/London'
+    }).formatToParts(input);
+
+    const part = (type: string) => d.find(p => p.type === type)?.value;
+
+    return `${part('year')}-${part('month')}-${part('day')}`
+
+}

src/lib/validation.ts

@@ -1,6 +1,17 @@
 /**
-* Checks if a string is a valid CRS
+ * Checks if a character code is a digit
+ */
+const isDigit = (c: number) => c >= 48 && c <= 57;
+
+/**
+ * Checks if a character code is an upper case letter
+ */
+const isUpper = (c: number) => c >= 65 && c <= 90;
+
+/**
+* Checks if a string is a valid CRS (Syntactically Only)
 * using byte level checking for max performance
+* @param CRS The CRS Code to be validated
 */
 export const IsValidCrs = (CRS: string): boolean => {
     if (CRS.length !== 3) return false;
@@ -15,8 +26,27 @@ export const IsValidCrs = (CRS: string): boolean => {
 }
 
 /**
- * Checks if a string is a valid TIPLOC
+ * Checks if a string is a valid RID, with 15-16 numeric characters
+ * @param rid The RID to validate
+ * @returns True/False - Whether valid or not
+ */
+export const IsValidRid = (rid: string): boolean => {
+    if (rid.length > 16 || rid.length < 15) {
+        return false
+    }
+    for (let i = 0; i < rid.length; i++) {
+        const char = rid.charCodeAt(i);
+        if (!isDigit(char)) {
+            return false
+        }
+    }
+    return true
+}
+
+/**
+ * Checks if a string is a valid TIPLOC (Syntactically Only)
  * using byte level checking for max performance
+ * @param TIPLOC The TIPLOC to be validated
  */
 export const IsValidTiploc = (TIPLOC: string): boolean => {
     const l = TIPLOC.length;
@@ -33,9 +63,10 @@ export const IsValidTiploc = (TIPLOC: string): boolean => {
 }
 
 /**
- * Checks if a string is a valid PIS Code
+ * Checks if a string is a valid PIS Code (Syntactically Only)
  * using byte level checking for max performance
  * ONLY GWR (4-digit) CODES SUPPORTED
+ * @param PIS The PIS Code to be validated
  */
 export const IsValidPis = (PIS: string): boolean => {
     if (PIS.length !== 4) return false;
@@ -44,4 +75,69 @@ export const IsValidPis = (PIS: string): boolean => {
         if (!(char >= 48 && char <= 57)) return false;
     }
     return true;
+}
+
+/**
+ * Checks if a string is the correct format for a Headcode
+ * USes byte level checking for max performance
+ * @param Headcode The headcode to be validated
+ */
+export const IsValidHeadcode = (Headcode: string): boolean => {
+    if (Headcode.length !== 4) return false;
+    const c0 = Headcode.charCodeAt(0);
+    const c1 = Headcode.charCodeAt(1);
+    const c2 = Headcode.charCodeAt(2);
+    const c3 = Headcode.charCodeAt(3);
+
+    return isDigit(c0) && isUpper(c1) && isDigit(c2) && isDigit(c3)
+}
+
+/**
+ * Checks if a string is the correct format for a TOC Code
+ */
+export const IsValidToc = (toc: string): boolean => {
+    if (toc.length !== 2) {
+        return false;
+    }
+
+    const c0 = toc.charCodeAt(0);
+    const c1 = toc.charCodeAt(1);
+    return isUpper(c0) && isUpper(c1);
+}
+
+/**
+ * Checks if a string is the correct format, and is a valid date
+ */
+export const IsValidDateStr = (s: string): boolean => {
+    if (s.length !== 10) return false;
+    if (s[4] !== '-' || s[7] !== '-') return false;
+
+    for (let i = 0; i < 10; i++) {
+        if (i === 4 || i === 7) continue;
+        const c = s.charCodeAt(i);
+        if (!isDigit(c)) return false;
+    }
+
+    const y = parseInt(s.substring(0, 4), 10);
+    const m = parseInt(s.substring(5, 7), 10) - 1; // JS months are 0-11
+    const d = parseInt(s.substring(8, 10), 10);
+
+    const date = new Date(y, m, d);
+
+    return (
+        date.getFullYear() === y &&
+        date.getMonth() === m &&
+        date.getDate() === d
+    );
+}
+
+/**
+ * Validates Geohash string against standard b32 alphabet
+ * (Syntactically Only validation)
+ * @param hash The geohash to be validated
+ * @param maxLen Defaults to 6 - which is enforced by the server, should not need changing
+ */
+export const IsValidGeoHash = (hash: string, maxLen: number = 6): boolean => {
+    const geoHashRegex = new RegExp(`^[0-9bcdefghjkmnpqrstuvwxyz]{1,${maxLen}}$`, 'i');
+    return geoHashRegex.test(hash);
 }

src/modules/locationFilter.ts

@@ -0,0 +1,16 @@
+import { ApiLocationFilter } from "@owlboard/api-schema-types";
+import type { BaseClient, ApiResult } from '../lib/base.js';
+
+export class LocationFilterModule {
+    constructor(private client: BaseClient) {}
+
+    async getLocationFilterData(customFetch?: typeof fetch): Promise<ApiResult<ApiLocationFilter.LocationFilterObject[]>> {
+        const path = '/locationFilter/data';
+
+        return this.client.request<ApiLocationFilter.LocationFilterObject[]>(
+            path,
+            {method: "GET"},
+            customFetch,
+        );
+    }
+}

src/modules/pis.ts

@@ -1,12 +1,12 @@
 import { ApiPisObject } from '@owlboard/api-schema-types';
 import type { BaseClient, ApiResult } from '../lib/base.js';
-import { IsValidCrs, IsValidTiploc, IsValidPis } from 'src/lib/validation.js';
-import { ValidationError } from 'src/lib/errors.js';
+import { IsValidCrs, IsValidPis } from '../lib/validation.js';
+import { ValidationError } from '../lib/errors.js';
 
 export class PisModule {
     constructor(private client: BaseClient) {}
 
-    async getByStartEndCrs(startCrs: string, endCrs: string): Promise<ApiResult<ApiPisObject.PisObjects[]>> {
+    async getByStartEndCrs(startCrs: string, endCrs: string, customFetch?: typeof fetch): Promise<ApiResult<ApiPisObject.PisObjects[]>> {
         if (!IsValidCrs(startCrs)) {
             throw new ValidationError("startCrs", "Invalid CRS Format")
         }
@@ -18,10 +18,10 @@ export class PisModule {
 
         return this.client.request<ApiPisObject.PisObjects[]>(path, {
             method: 'GET',
-        });
+        }, customFetch);
     }
 
-    async getByCode(code: string): Promise<ApiResult<ApiPisObject.PisObjects[]>> {
+    async getByCode(code: string, customFetch?: typeof fetch): Promise<ApiResult<ApiPisObject.PisObjects[]>> {
         if (!IsValidPis(code)) {
             throw new ValidationError("code", "Invalid PIS Code Format")
         }
@@ -30,6 +30,6 @@ export class PisModule {
 
         return this.client.request<ApiPisObject.PisObjects[]>(path, {
             method: 'GET',
-        })
+        }, customFetch)
     }
 }

src/modules/stationData.ts

@@ -0,0 +1,37 @@
+import { ApiStationsNearestStations } from '@owlboard/api-schema-types';
+import type { BaseClient, ApiResult } from '../lib/base.js';
+import { IsValidGeoHash } from '../lib/validation.js';
+import { ValidationError } from '../lib/errors.js';
+import Geohash from 'latlon-geohash';
+
+export class StationDataModule {
+    constructor(private client: BaseClient) {}
+
+    /**
+     * Generates a 6-char Geohash for the given co-ordinates
+     * @param lt Latitude
+     * @param ln Longitude
+     * @returns Geohash as string
+     */
+    generateGeohash(lt: number, ln: number): string {
+        return Geohash.encode(lt, ln, 6);
+    }
+
+    /**
+     * 
+     * @param geohash Geohash as string (up to six characters), generate using this.generateGeohash()
+     * @returns Nearest Stations API Response (CRS, Name)
+     */
+    async getNearestStations(geohash: string, customFetch?: typeof fetch): Promise<ApiResult<ApiStationsNearestStations.StationsNearestStations[]>> {
+        if (!IsValidGeoHash(geohash)) {
+            throw new ValidationError("hash", "Invalid Geohash requested");
+        }
+
+        const path = `/stationData/nearest/${geohash}`;
+        return this.client.request<ApiStationsNearestStations.StationsNearestStations[]>(path, {
+            method: 'GET',
+        }, customFetch)
+    }
+
+    // getStationSate(crs: string){}
+}

src/modules/trains.ts

@@ -0,0 +1,45 @@
+import { ApiTrainsTrainByHeadcode, ApiTrainsTrainDetails } from '@owlboard/api-schema-types';
+import type { BaseClient, ApiResult } from '../lib/base.js';
+import { IsValidHeadcode, IsValidRid, IsValidToc, IsValidDateStr } from '../lib/validation.js';
+import { ensureDateString } from '../lib/helpers.js';
+import { ValidationError } from '../lib/errors.js';
+
+export class TrainsModule {
+    constructor(private client: BaseClient) { }
+
+    async getByHeadcode(headcode: string, date: string | Date = new Date, toc: string = "", customFetch?: typeof fetch): Promise<ApiResult<ApiTrainsTrainByHeadcode.TrainByHeadcodeResponse[]>> {
+        if (!IsValidHeadcode(headcode)) {
+            throw new ValidationError("headcode", "Invalid headcode format")
+        }
+        if (toc !== "" && !IsValidToc(toc)) {
+            throw new ValidationError("TOC", "Invalid TOC Format, needs to be two characters");
+        }
+
+        const dateStr = ensureDateString(date);
+        if (!IsValidDateStr(dateStr)) {
+            throw new ValidationError("Date", "Invalid date format, need YYYY-MM-DD");
+        }
+
+        const searchParams = new URLSearchParams();
+        searchParams.append('d', dateStr);
+        searchParams.append('h', headcode);
+        if (toc) searchParams.append('t', toc);
+
+        const path = `/trains?${searchParams.toString()}`;
+
+        return this.client.request<ApiTrainsTrainByHeadcode.TrainByHeadcodeResponse[]>(path, {
+            method: 'GET',
+        }, customFetch);
+    }
+
+    async getByRid(rid: string, customFetch?: typeof fetch): Promise<ApiResult<ApiTrainsTrainDetails.TrainDetailsResponse>> {
+        if (!IsValidRid(rid)) {
+            throw new ValidationError("RID", "Invalid RID format, must be 15-16 numerals")
+        }
+
+        const path = `/train/${rid}`
+        return this.client.request<ApiTrainsTrainDetails.TrainDetailsResponse>(path, {
+            method: 'GET',
+        }, customFetch);
+    }
+}

tsconfig.json

@@ -7,9 +7,9 @@
 
     // Environment Settings
     // See also https://aka.ms/tsconfig/module
-    "module": "esnext",
+    "module": "nodenext",
     "target": "esnext",
-    "moduleResolution": "bundler",
+    "moduleResolution": "nodenext",
     "baseUrl": ".",
     "types": [],
     // For nodejs:
@@ -21,6 +21,7 @@
     "sourceMap": true,
     "declaration": true,
     "declarationMap": true,
+    "composite": true,
 
     // Stricter Typechecking Options
     "noUncheckedIndexedAccess": true,